Codecov Report

Base: 31.41% // Head: 31.41% // No change to project coverage 👍

Coverage data is based on head (41ee662) compared to base (31cb306).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 41ee662 differs from pull request most recent head bd536c0. Consider uploading reports for the commit bd536c0 to get more accurate results

@@            Coverage Diff            @@
##               main    #3032   +/-   ##
=========================================
  Coverage     31.41%   31.41%           
  Complexity      253      253           
=========================================
  Files           110      110           
  Lines          1862     1862           
  Branches        218      217    -1     
=========================================
  Hits            585      585           
  Misses         1162     1162           
  Partials        115      115           

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

I just tested this and it seems to work. 🚀

Only the sort option may not work as expected currently but this may be an already existing issue. (changing sorting between the speicifc options sometimes does not change the contacts order even though it should theoratically be changed in order to reflect the new setting).

Also, can we somehow remove the strange looking border betweeen the input field and the arrow for creating the new address book?

Also, can we make it more clear when an address book is disabled by addding (disaabled) behind its name then?
really ugly mockup:

Also, the share button should probably switch to a different icon when a calendar is alredy shared? (and the icon is moving down when the share view is expanded)

additionally, importing contacts is very easily to break e.g. by choosing a local non-ics file for import or choosing from files and clicking on the close button of the file picker

One step at a time please @szaimen. Let's move the settings in this PR and keep the redesign for a follow-up.

One step at a time please @szaimen. Let's move the settings in this PR and keep the redesign for a follow-up.

Fine by me. I'll create a follow-up ticket

Done in #3033

Done in #3033

Thank you @szaimen for the valuable feedback! I agree with your points and will work on them asap. Yesterday it was a bit urgent to finish a first state and follow-ups will be done in a next days.

@JuliaKirschenheuter are there any blockers for the setting sections?

Please squash